Allow trailing semi-colon after typedef - #7
Open
lizard-boy wants to merge 1 commit into
Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added support for trailing semicolons after typedef and const definitions, improving compatibility with other Thrift parsers.
- Modified
parseTypedefinsrc/main/parser.tsto consume optional trailing semicolons - Added new test fixtures and solutions in
src/tests/parserandsrc/tests/scannerto verify the new behavior - Updated
src/tests/parser/parser.spec.tsandsrc/tests/scanner/scanner.spec.tswith new test cases for trailing semicolons - Implemented changes consistently across parser and scanner components
7 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings
Comment on lines
+1
to
+2
| const string test = 'asdf'; | ||
| typedef i32 MyInteger; |
There was a problem hiding this comment.
logic: Duplicate const declaration on line 3
| @@ -0,0 +1,4 @@ | |||
| const string test = 'asdf'; | |||
| typedef i32 MyInteger; | |||
There was a problem hiding this comment.
logic: Duplicate typedef declaration on line 4
Comment on lines
+3
to
+4
| const string test = 'asdf' | ||
| typedef i32 MyInteger |
There was a problem hiding this comment.
style: Inconsistent use of semicolons
| } | ||
| } | ||
| }, | ||
| { |
There was a problem hiding this comment.
logic: Missing semicolon after const definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not exactly in the spec, but most Thrift parsers allow trailing semi-colon after typedef.